Tomas Jelinek has posted comments on this change. Change subject: webadmin: Added place holder for watchdog model. ......................................................................
Patch Set 17: (2 comments) https://gerrit.ovirt.org/#/c/36688/17/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java: Line 1615: for (VmWatchdogAction action : VmWatchdogAction.values()) { Line 1616: watchDogActions.add(action); Line 1617: } Line 1618: getWatchdogAction().setItems(watchDogActions); Line 1619: getWatchdogAction().setIsChangable(false); > At the beginning, when no Watchdog model is chosen, Watchdog action should ok Line 1620: Line 1621: setWatchdogModel(new NotChangableForVmInPoolListModel<VmWatchdogType>()); Line 1622: getWatchdogModel().getSelectedItemChangedEvent().addListener(this); Line 1623: Line 1840: > please remove whitespace but this whitespace has to be removed anyway ;) -- To view, visit https://gerrit.ovirt.org/36688 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice4111935a0ec3bb29237660702e536adbc34d14 Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomer Saban <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Tomer Saban <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
