Maor Lipchuk has posted comments on this change. Change subject: core: GetUnregisteredCinderDiskByIdAndStorageDomainIdQuery ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/39651/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetUnregisteredCinderDiskByIdAndStorageDomainIdQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetUnregisteredCinderDiskByIdAndStorageDomainIdQuery.java: Line 21: Line 22: @Override Line 23: protected void executeQueryCommand() { Line 24: Disk diskFromDao = getDbFacade().getDiskDao().get(getParameters().getEntityId()); Line 25: if (diskFromDao != null) { Please add a log here that the disk already exists in the DB and therefore should not be fetched from the VolumeProvider Line 26: getQueryReturnValue().setReturnValue(null); Line 27: return; Line 28: } Line 29: Volume Volume = getVolumeProviderProxy().getVolumeById(getParameters().getEntityId().toString()); -- To view, visit https://gerrit.ovirt.org/39651 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idc4774771fa77866db85bb0cbffecc702237ce6f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
