Sahina Bose has submitted this change and it was merged.
Change subject: webadmin : Fix geo-rep config issue
......................................................................
webadmin : Fix geo-rep config issue
This patch fixes the following issues:
1. Multiple update actions from geo-rep config list
Earlier the List of callbacks passed was unmodifiable
list of 1 non-null callback as returned by the Arrays.asList()
and hence when the Frontend's recursive implementation
of runMultipleActions tries to remove the entries on each
recursive call, it used to fail.
This patch handles it passing a modifiable list as under
new ArrayList(Arrays.asList(<collection>))
2. When multiple rows have SelectionCell the previously implemented
method used to return the value at selectedIndex of
last added SelectedCell. Hence to overcome this, this patch uses
the appropriately returned selectedIndex and uses this index to
get the correct selected value from the allowed values of the
current row.
Change-Id: If340d6c66bd21248f9d13d67f66e180022cfe6ac
Signed-off-by: Anmol Babu <[email protected]>
---
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/GlusterConfigAwareCell.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeoRepListModel.java
2 files changed, 11 insertions(+), 11 deletions(-)
Approvals:
anmolbabu: Looks good to me, but someone else must approve
Sahina Bose: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39986
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If340d6c66bd21248f9d13d67f66e180022cfe6ac
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5-gluster
Gerrit-Owner: Sahina Bose <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: anmolbabu <[email protected]>
Gerrit-Reviewer: [email protected]
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
