Sahina Bose has submitted this change and it was merged. Change subject: engine, webadmin: use slave host id instead of slave host name ......................................................................
engine, webadmin: use slave host id instead of slave host name The canDoAction of create georep session command checks if host is monitored by engine and tries to get host based on the passed host details. Previously,this used to be obtained using host name and UI used to pass the host name which is VDS#getName but the backend expected dns resolvable name which is provided by VDS#getHostName. The UI can't pass VDS#getHostName because its not available in there. The UI lists vds as obtained from the bricks of eligible/non-eligible volumes. The volume can provide only brick servernames and server ids. So, its better to obtain vds based on its id rather than on name. The above reasons required this change to be introduced. Change-Id: I4440eddbc2616c7ca89feaae3ba0e67d93562213 Signed-off-by: Anmol Babu <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeGeoRepSessionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GeoRepSessionCommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeGeoRepSessionCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/gluster/GlusterVolumeGeoRepSessionParameters.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterGeoRepDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterGeoRepDaoDbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/GlusterGeoRepDaoTest.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeGeoRepCreateModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeoRepListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GlusterVolumeGeoRepCreateSessionPopupView.java M packaging/dbscripts/gluster_georep_sp.sql 11 files changed, 53 insertions(+), 48 deletions(-) Approvals: anmolbabu: Verified Kanagaraj M: Looks good to me, but someone else must approve Sahina Bose: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39868 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4440eddbc2616c7ca89feaae3ba0e67d93562213 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
