Alon Bar-Lev has posted comments on this change.
Change subject: pki: use PKCS#12 format to store keys
......................................................................
Patch Set 10: (3 inline comments)
Thanks!
....................................................
File backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql
Line 179: select
fn_db_add_config_value('JobCleanupRateInMinutes','10','general');
Line 180: select fn_db_add_config_value('JobPageSize','100','general');
Line 181: select fn_db_add_config_value('keystorePass','NoSoup4U','general');
Line 182: --Handling Keystore URL
Line 183: select
fn_db_add_config_value('keystoreUrl','keys/engine.p12','general');
Done
Line 184: select fn_db_add_config_value('LdapQueryPageSize','1000','general');
Line 185: select fn_db_add_config_value('LDAPQueryTimeout','30','general');
Line 186: select fn_db_add_config_value('LDAPConnectTimeout','30','general');
Line 187: select fn_db_add_config_value('LDAPOperationTimeout','30','general');
Line 427: select
fn_db_add_config_value('TimeoutToResetVdsInSeconds','60','general');
Line 428: select
fn_db_add_config_value('TimeToReduceFailedRunOnVdsInMinutes','30','general');
Line 429: select fn_db_add_config_value('TruststorePass','NoSoup4U','general');
Line 430: --Handling Truststore URL
Line 431: select
fn_db_add_config_value('TruststoreUrl','.truststore','general');
Done
Line 432: select
fn_db_add_config_value('UknownTaskPrePollingLapse','60000','general');
Line 433: select fn_db_add_config_value('UserDefinedVMProperties','','2.2');
Line 434: select fn_db_add_config_value('UserDefinedVMProperties','','3.0');
Line 435: select fn_db_add_config_value('UserDefinedVMProperties','','3.1');
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssl/AuthSSLProtocolSocketFactory.java
Line 301: }
Line 302: keymanagers = createKeyManagers(keystore,
this.keystorePassword);
Line 303: }
Line 304: if (this.truststoreUrl != null) {
Line 305: KeyStore keystore = createKeyStore("JKS",
this.truststoreUrl, this.truststorePassword);
>From commit message: "... It does not handle the trust store which is left as
>JKS for now."
Line 306: if (LOG.isDebugEnabled()) {
Line 307: Enumeration<String> aliases = keystore.aliases();
Line 308: while (aliases.hasMoreElements()) {
Line 309: String alias = aliases.nextElement();
--
To view, visit http://gerrit.ovirt.org/6883
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2abda5778477faff09798a43cf3dc96435efb272
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
