Daniel Erez has posted comments on this change. Change subject: core: GetAllDisksByStorageDomainIdQuery - support Cinder disks ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/39648/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllDisksByStorageDomainIdQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllDisksByStorageDomainIdQuery.java: Line 27: if (storageDomain.getStorageType().isCinderDomain()) { Line 28: List<DiskImage> diskImages = getDbFacade().getDiskImageDao().getAllForStorageDomain(getParameters().getId()); Line 29: getQueryReturnValue().setReturnValue(diskImages); Line 30: } Line 31: else { > please use else in the same line Done Line 32: List<DiskImage> diskImages = Line 33: getDbFacade().getDiskImageDao().getAllSnapshotsForStorageDomain(getParameters().getId()); Line 34: Line 35: Map<Guid, DiskImage> diskImagesMap = new HashMap<Guid, DiskImage>(); -- To view, visit https://gerrit.ovirt.org/39648 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3aa49823d72175f75dcc077c56b7ea53754076f1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
