Maor Lipchuk has posted comments on this change. Change subject: core: support hot plug for Cinder disks ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/39658/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java: Line 94: } Line 95: catch (OpenStackResponseException ex) { Line 96: addCustomValue("DiskAlias", cinderDisk.getDiskAlias()); Line 97: auditLogDirector.log(this, AuditLogType.CINDER_DISK_CONNECTION_FAILURE); Line 98: throw ex; You are using almost the same logic as updateCinderDisksConnections(), can't we re-use it Line 99: } Line 100: } Line 101: runVdsCommand(commandType, new HotPlugDiskVDSParameters(getVm().getRunOnVds(), Line 102: getVm(), disk, vmDevice)); -- To view, visit https://gerrit.ovirt.org/39658 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe00f9e568a5ee0da1667bb8e57ac075cd5d03ed Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
