Arik Hadas has uploaded a new change for review. Change subject: webadmin: fix cpu profile selection on import vm ......................................................................
webadmin: fix cpu profile selection on import vm CPU profile and quota are set in the import-VM dialog upon cluster change. However, when switching between the first screen and the second screen in the new import dialog, it might be that the cluster will not change (as a result of the injection of ClusterListModel in ImportVmFromExportDomainModel) so these fields will not be set. The solution is to clear the cluster selection before setting its new values to ensure that a cluster selection change will be detected. Change-Id: I922ccf0b27f1fb971f7b26a7a9cc6aa6ce9833f7 Signed-off-by: Arik Hadas <[email protected]> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromExportDomainModel.java 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/26/40026/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromExportDomainModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromExportDomainModel.java index a081286..7a69298 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromExportDomainModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromExportDomainModel.java @@ -218,9 +218,11 @@ if (hasQuota) { getClusterQuota().setIsAvailable(true); } + getCluster().getSelectedItemChangedEvent().addListener(clusterChangedListener); // get cluster if (dataCenter != null) { + getCluster().setItems(null); AsyncDataProvider.getInstance().getClusterByServiceList(new AsyncQuery(ImportVmFromExportDomainModel.this, new INewAsyncCallback() { @Override public void onSuccess(Object model, Object returnValue) { -- To view, visit https://gerrit.ovirt.org/40026 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I922ccf0b27f1fb971f7b26a7a9cc6aa6ce9833f7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
