Lior Vernia has posted comments on this change. Change subject: webadmin: adding network-out-of-sync to SubTabNetworkHost ......................................................................
Patch Set 9: (2 comments) https://gerrit.ovirt.org/#/c/38291/9/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/VLanPanel.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/VLanPanel.java: Line 102: Line 103: private Grid createBaseVlanRow(Widget checkBoxWidget, Line 104: boolean networkManagementFlag, Line 105: String networkName, Line 106: VdsNetworkInterface iface, You only care about the iface's NetworkImplementationDetails, why not pass that instead? Line 107: String address) { Line 108: Grid row = new Grid(1, 4); Line 109: row.getColumnFormatter().setWidth(0, VLanPanel.CHECK_BOX_COLUMN_WIDTH); Line 110: row.getColumnFormatter().setWidth(1, VLanPanel.OUT_OF_SYNC_WIDTH); Line 117: if (networkManagementFlag) { Line 118: networkNameLabel.getElement().getStyle().setFontWeight(FontWeight.BOLD); Line 119: networkNameLabel.setText("* " + networkName); //$NON-NLS-1$ Line 120: } Line 121: row.setWidget(0, 1, createSyncPanel(iface.getNetworkImplementationDetails() == null ? true Maybe put the null check logic inside createSyncPanel and pass it NetworkImplementationDetails instead of boolean? Line 122: : iface.getNetworkImplementationDetails().isInSync())); Line 123: row.setWidget(0, 2, networkNameLabel); Line 124: row.setWidget(0, 3, new Label(address)); Line 125: return row; -- To view, visit https://gerrit.ovirt.org/38291 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id200f9c135f1097572feac300e255a438cfb295a Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eliraz Levi <[email protected]> Gerrit-Reviewer: Eliraz Levi <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
