Roy Golan has posted comments on this change.
Change subject: core: Cleanup VMCommand
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java
Line 362: getActionType().getActionGroup()));
Line 363: return permissionList;
Line 364: }
Line 365:
Line 366: protected int getBlockSparseInitSizeInGb() {
what about getxxxDAO? so either we camel case acronyms or not.
the main cons for me is when 2 acronyms meet in the same var name where
upper-casing can be ugly - e.g getVMDAO or getVmDao?
for me its the latter. IMHO its usually clearer.
Line 367: return Config.<Integer>
GetValue(ConfigValues.InitStorageSparseSizeInGB).intValue();
Line 368: }
Line 369:
Line 370: protected List<ValidationError> validateCustomProperties(VmStatic
vmStaticFromParams) {
--
To view, visit http://gerrit.ovirt.org/8263
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6750a6bf6bac763a73f5e7eb9912acf7bd0c50e0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharad Mishra <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
