Hello Alon Bar-Lev,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/40042
to review the following change.
Change subject: pki: do not use /dev/fd
......................................................................
pki: do not use /dev/fd
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1209281
Change-Id: I68d3c04e38d2ee17a6ac72a3050544b14a79c039
Signed-off-by: Alon Bar-Lev <[email protected]>
(cherry picked from commit 7621286ba8f65fd91d0b2e670fe2dfbb06f8b277)
---
M packaging/bin/pki-pkcs12-extract.sh
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/42/40042/1
diff --git a/packaging/bin/pki-pkcs12-extract.sh
b/packaging/bin/pki-pkcs12-extract.sh
index ede7a0d..7a86d70 100755
--- a/packaging/bin/pki-pkcs12-extract.sh
+++ b/packaging/bin/pki-pkcs12-extract.sh
@@ -14,7 +14,7 @@
[ -z "${passout}" ] && extra_args="${extra_args} -nodes"
if [ "${key}" = - ]; then
- key=/dev/fd/1
+ key=/proc/self/fd/1
else
touch "${key}"
chmod go-rwx "${key}" || die "Cannot set key permissions"
@@ -42,7 +42,7 @@
common_backup "${cert}"
if [ "${cert}" = - ]; then
- cert=/dev/fd/1
+ key=/proc/self/fd/1
else
touch "${cert}"
chmod a+r "${cert}" || die "Cannot set certificate permissions"
--
To view, visit https://gerrit.ovirt.org/40042
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I68d3c04e38d2ee17a6ac72a3050544b14a79c039
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
