Alon Bar-Lev has posted comments on this change. Change subject: packaging: updated handling of pgpass file between versions ......................................................................
Patch Set 3: (1 inline comment) .................................................... File packaging/fedora/setup/common_utils.py Line 304 Line 305 Line 306 Line 307 Line 308 Again, I would have put: os.environ["PGPASSFILE"] = basedefs.DB_PASS_FILE At main... and not make this dirty hack... And I still don't understand why we have no clue of which processes actually needs this. -- To view, visit http://gerrit.ovirt.org/8135 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d44297725d7270982e8724e4aeefda8bc7a88e2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Kiril Nesenko <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
