Arik Hadas has submitted this change and it was merged. Change subject: webadmin: prevent class cast exception on import vm ......................................................................
webadmin: prevent class cast exception on import vm This patch is a workaround for a problem with StorageDisksListModel that cause class-cast exception: in ImportVmFromExportDomainModel we set the items in StorageDisksListModel to StorageDomains. However, in StorageDisksListModel#updateActionAvailability we expect the getSelectedItems method to return DiskImages. Probably something went wrong in b13dc92e where StorageDisksListModel was introduced in ImportVmFromExportDomainModel. This patch is only a workaround that eliminates the error by clearing the storage-domain before loading new ones so the previous selected item will be null and we won't get that exception. Proper solution should be introduced separately. Change-Id: I28f9eee614ba5e6eeef9f8aa88337aab9a90a2f9 Signed-off-by: Arik Hadas <[email protected]> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromExportDomainModel.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/40056 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I28f9eee614ba5e6eeef9f8aa88337aab9a90a2f9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
