Omer Frenkel has posted comments on this change. Change subject: Allow to avoid lock screen on spice disconnect ......................................................................
Patch Set 18: (3 comments) backend looks ok, minor comments https://gerrit.ovirt.org/#/c/34079/18//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2014-10-13 15:12:26 +0200 Line 4: Commit: Vinzenz Feenstra <[email protected]> Line 5: CommitDate: 2015-04-20 12:29:46 +0200 Line 6: Line 7: Allow to avoid lock screen on spice disconnect it would be nice to have a little description of the patch here, like what it changes / what is the issue and how the patch solve it, shortly.. Line 8: Line 9: Change-Id: Ia2ef5ffaceed619f6630b56a7156f25e9111fd9e Line 10: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1171638 https://gerrit.ovirt.org/#/c/34079/18/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java: Line 263: @EditableOnVmStatusField Line 264: @EditableOnTemplate Line 265: private String customProperties; Line 266: Line 267: @EditableField please add @CopyOnNewVersion this will allow automatically updating the value according to new template version Line 268: private ConsoleDisconnectAction consoleDisconnectAction; Line 269: Line 270: public VmBase() { Line 271: name = ""; https://gerrit.ovirt.org/#/c/34079/18/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetVmTicketVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetVmTicketVDSCommand.java: Line 63: private Map<String, String> getUidParams() { Line 64: Map<String, String> params = new HashMap<>(); Line 65: params.put("userName", getParameters().getUserName()); Line 66: params.put("userId", getParameters().getUserId().toString()); Line 67: params.put("disconnectAction", getParameters().getDisconnectAction()); why here in addition to the previous addition above? in case includeUserData == true this value will be added twice Line 68: return params; Line 69: } Line 70: -- To view, visit https://gerrit.ovirt.org/34079 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2ef5ffaceed619f6630b56a7156f25e9111fd9e Gerrit-PatchSet: 18 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Martin Betak <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
