Michael Kublin has uploaded a new change for review. Change subject: core: several multiple RemoveVmCommand get java.lang.RuntimeException when restarting engine ......................................................................
core: several multiple RemoveVmCommand get java.lang.RuntimeException when restarting engine The bug was caused because of unneeded update at CommandBase of parameters of async tasks, during update were passed parameters of parent command, the update is unneeded because of parameters are passed during creation of task, because of update was done partitial we got java.lang.RuntimeException. Solution: to remove unneded update, also we will have additional benefit: reduced at least two updates query on every task Change-Id: Ie885b5d069abf0592454f6834466d3fcb5a47c85 Bug-Url: https://bugzilla.redhat.com/861154 Signed-off-by: Michael Kublin <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 0 insertions(+), 7 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/91/8291/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java index e5d6ed5..242c0f9 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java @@ -931,13 +931,6 @@ logCommand(); } if (getSucceeded()) { - // only after creating all tasks, we can start polling them (we - // don't want - // to start polling before all tasks were created, otherwise we - // might change - // the VM/VmTemplate status to 'Down'/'OK' too soon. - updateTasksWithActionParameters(); - startPollingAsyncTasks(); } } finally { -- To view, visit http://gerrit.ovirt.org/8291 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie885b5d069abf0592454f6834466d3fcb5a47c85 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
