Juan Hernandez has posted comments on this change. Change subject: packaging: Make DB connection pool configurable ......................................................................
Patch Set 1: (4 inline comments) I am taking care of the configurable log file paths in the following change: http://gerrit.ovirt.org/8297 .................................................... File packaging/fedora/engine-service.xml.in Line 26 Line 27 Line 28 Line 29 Line 30 Yes, it should be $getString('ENGINE_LOG')/server.log. Line 99 Line 100 Line 101 Line 102 Line 103 Did you find a situation where you need to change it? If the answer is yes then I will include it, otherwise I'd rather wait. Line 114 Line 115 Line 116 Line 117 Line 118 Do you mean the interval or the path? The path should be $getString('ENGINE_VAR')/deployments. Line 158 Line 159 Line 160 Line 161 Line 162 These parameters are for JCA connectors that use the work manager API. We don't use that kind of connectors (we don't use any kind of connectors other than JDBC, and those don't use the work manager API). -- To view, visit http://gerrit.ovirt.org/8216 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I607e74df406128c7fd9b2e1496b3efa08e11fbac Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
