Michael Kublin has posted comments on this change.
Change subject: core: Disabling plug disks command during snapshoting (#844440)
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
Line 93: getParameters().getDescription(),
Line 94: getParameters().getSnapshotType(),
Line 95: getVm(),
Line 96: getCompensationContext());
Line 97:
These is wrong, if you want to prevent hot plug you should add appropriate
check to
hot plug command - SnapshotsValidator.vmNotDuringSnapshot(), lock is used for
other purposes.
Line 98: setActionReturnValue(createdSnapshotId);
Line 99:
Line 100: if (getDisksList().isEmpty()) {
Line 101: getParameters().setTaskGroupSuccess(true);
--
To view, visit http://gerrit.ovirt.org/8298
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4980c8cff7aec9bd10bba344f9592bbbf1c20b8d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
