Piotr Kliczewski has posted comments on this change. Change subject: construct jsonrpc with identifier name. ......................................................................
Patch Set 6: (2 comments) Please update 0000_config.sql as well. https://gerrit.ovirt.org/#/c/39888/6/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java: Line 2041: MaxWriteIopsUpperBoundQosValue, Line 2042: Line 2043: @TypeConverterAttribute(Boolean.class) Line 2044: @DefaultValueAttribute("false") Line 2045: HostNameIdentifier, Please change name or give description what is meant for. Line 2046: Line 2047: /** Line 2048: * Defines the number of history values storable by the engine for cpu/network/memory usage of a VM Line 2049: */ https://gerrit.ovirt.org/#/c/39888/6/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcUtils.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcUtils.java: Line 55: String protocol) { Line 56: ClientPolicy connectionPolicy = Line 57: new ClientPolicy(connectionTimeout, connectionRetry, heartbeat, IOException.class); Line 58: ClientPolicy clientPolicy = new ClientPolicy(clientTimeout, connectionRetry, heartbeat, IOException.class); Line 59: connectionPolicy.setIdentifier(hostname); please add check here as well. Line 60: return createClient(hostname, port, connectionPolicy, clientPolicy, isSecure, type, protocol); Line 61: } Line 62: Line 63: private static JsonRpcClient createClient(String hostname, -- To view, visit https://gerrit.ovirt.org/39888 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic423322de3f1e0d1862d147a3b529f5c047d8b02 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eldad Marciano <[email protected]> Gerrit-Reviewer: Eldad Marciano <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
