Keith Robertson has posted comments on this change. Change subject: packaging: Updated UI prompts in wizard ......................................................................
Patch Set 2: (5 inline comments) .................................................... File packaging/fedora/setup/output_messages.py Line 118: INFO_CONF_PARAMS_FQDN_PROMPT="Host fully qualified domain name. Note: this name should be fully resolvable" Line 119: INFO_CONF_PARAMS_CA_PASS_USAGE="The password for the CA private key" Line 120: INFO_CONF_PARAMS_CA_PASS_PROMPT="Password for the CA private key" Line 121: INFO_CONF_PARAMS_AUTH_PASS_USAGE="Password for internal admin user" Line 122: INFO_CONF_PARAMS_AUTH_PASS_PROMPT="Enter a password for an internal %s administrator user (admin@internal)" % basedefs.APP_NAME This is OK as long as the internal administrator is always admin@internal. Also, it might read better if you worded it like this... "Enter a password for the %s internal administrator (%s):" % (basedefs.APP_NAME, ADMIN_USER) Line 123: INFO_CONF_PARAMS_ORG_NAME_USAGE="Organization Name for the Certificate" Line 124: INFO_CONF_PARAMS_ORG_NAME_PROMPT="Organization Name for the Certificate" Line 125: INFO_CONF_PARAMS_DC_TYPE_USAGE="Default Data Center Storage Type" Line 126: INFO_CONF_PARAMS_DC_TYPE_PROMPT="The default storage type you will be using " Line 132: INFO_CONF_PARAMS_NFS_DESC_PROMPT="Display name for the ISO Domain" Line 133: INFO_CONF_PARAMS_MAC_RANGE_USAGE="MAC range for the virtual machines, e.g. 00:11:22:33:44:00-00:11:22:33:44:FF" Line 134: INFO_CONF_PARAMS_MAC_RANG_PROMPT="MAC range for the virtual machines" Line 135: INFO_CONF_PARAMS_DB_PASSWD_USAGE="Password for the local database administrator" Line 136: INFO_CONF_PARAMS_DB_PASSWD_PROMPT="Enter a password for a local %s DB admin user (%s)" % (basedefs.APP_NAME, basedefs.DB_USER) You could probably consolidate the local and remote DB prompt(s) to the flow below. I am not sure why the user needs different prompts for a local DB versus a remote DB. Simply, prompt them for the IP, ask them for the admin user name, then ask for the admin PW. - Enter the hostname or IP address of the DB server (default:127.0.0.1): - Enter the port number for the DB on %s: - Enter the admin user for the DB on 127.0.0.1 (default=postgres): - Enter a password for the %s DB admin user (%s): <-- Password promt Line 137: INFO_CONF_PARAMS_PASSWD_CONFIRM_PROMPT="Confirm password" Line 138: Line 139: #Remote DB interaction Line 140: INFO_CONF_PARAMS_REMOTE_DB_USAGE="Select local or remote DB server" Line 142: INFO_CONF_PARAMS_USE_DB_HOST_USAGE="Hostname or IP address of the DB server." Line 143: INFO_CONF_PARAMS_USE_DB_HOST_PROMPT="\nEntering a remote %s DB configuration section. All the configuration parameters should be provided by the remote DB administrator.\ Line 144: \n\nEnter the host IP or host name where %s DB is running" % (basedefs.APP_NAME, basedefs.APP_NAME) Line 145: INFO_CONF_PARAMS_USE_DB_PORT_USAGE="Connection port for the remote DB" Line 146: INFO_CONF_PARAMS_USE_DB_PORT_PROMPT="Enter the DB port number" "Enter the port number for the DB on %s:" % DB_IP_HERE Line 147: INFO_CONF_PARAMS_DB_ADMIN_USAGE="Remote DB admin user" Line 148: INFO_CONF_PARAMS_DB_ADMIN_PROMPT="Enter the remote DB user name" Line 149: INFO_CONF_PARAMS_REMOTE_DB_PASSWD_USAGE="Password for the remote database user" Line 150: INFO_CONF_PARAMS_REMOTE_DB_PASSWD_PROMPT="Enter the password for the remote DB user" Line 146: INFO_CONF_PARAMS_USE_DB_PORT_PROMPT="Enter the DB port number" Line 147: INFO_CONF_PARAMS_DB_ADMIN_USAGE="Remote DB admin user" Line 148: INFO_CONF_PARAMS_DB_ADMIN_PROMPT="Enter the remote DB user name" Line 149: INFO_CONF_PARAMS_REMOTE_DB_PASSWD_USAGE="Password for the remote database user" Line 150: INFO_CONF_PARAMS_REMOTE_DB_PASSWD_PROMPT="Enter the password for the remote DB user" Enter the password for the DB user (%s): % DB_USER_NAME_HERE Line 151: INFO_CONF_PARAMS_DB_SECURE_CONNECTION_USAGE="Should the connection to the DB be secure? (The support must be configured on the remote DB server)" Line 152: INFO_CONF_PARAMS_DB_SECURE_CONNECTION_PROMPT="Configure a secure connection? (make sure SSL is configured on the remote DB server)" Line 153: Line 154: Line 147: INFO_CONF_PARAMS_DB_ADMIN_USAGE="Remote DB admin user" Line 148: INFO_CONF_PARAMS_DB_ADMIN_PROMPT="Enter the remote DB user name" Line 149: INFO_CONF_PARAMS_REMOTE_DB_PASSWD_USAGE="Password for the remote database user" Line 150: INFO_CONF_PARAMS_REMOTE_DB_PASSWD_PROMPT="Enter the password for the remote DB user" Line 151: INFO_CONF_PARAMS_DB_SECURE_CONNECTION_USAGE="Should the connection to the DB be secure? (The support must be configured on the remote DB server)" If you're going to make an SSL JDBC connection, don't you also want to offer server validation via a keystore or CA? Currently, we the SDK requires server validation. Wouldn't you want the same behaviour for the JDBC connection? Line 152: INFO_CONF_PARAMS_DB_SECURE_CONNECTION_PROMPT="Configure a secure connection? (make sure SSL is configured on the remote DB server)" Line 153: Line 154: Line 155: #Auth domain -- To view, visit http://gerrit.ovirt.org/8307 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iad3fd914c62669f67f134f269f6f6a8d08a5c8c5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Keith Robertson <[email protected]> Gerrit-Reviewer: Kiril Nesenko <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> Gerrit-Reviewer: Yaniv Kaul <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
