Itamar Heim has posted comments on this change.
Change subject: Engine: set Rhev-H upgrade version via config value (#842767)
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
Line 1488: SSHInactivityHardTimoutSeconds(383),
Line 1489:
Line 1490: @TypeConverterAttribute(String.class)
Line 1491: @DefaultValueAttribute("1.0.0.0")
Line 1492: RhevHUpgradeVersion(384),
this config isn't used at all? what is it for?
Line 1493:
Line 1494: Invalid(65535);
Line 1495:
Line 1496: private int intValue;
....................................................
Commit Message
Line 5: CommitDate: 2012-09-13 12:09:08 +0300
Line 6:
Line 7: Engine: set Rhev-H upgrade version via config value (#842767)
Line 8:
Line 9: https://bugzilla.redhat.com/show_bug.cgi?id=842767
commit message isn't clear enough - commit message should describe the issue
and how it is fixed
Line 10:
Line 11: Change-Id: I042ae5263d565787ea7460f1d5f59beb77acff8b
--
To view, visit http://gerrit.ovirt.org/7430
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I042ae5263d565787ea7460f1d5f59beb77acff8b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
