Michael Pasternak has posted comments on this change.
Change subject: restapi: Create User - Validate That Domain Was Passed
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendUsersResource.java
Line 38:
Line 39: @Override
Line 40: public Response add(User user) {
Line 41: validateParameters(user, "userName");
Line 42: if (!user.getUserName().contains("@")) {
if username is 'user@', you'll won't fail request with missing domain, and will
end up
with BAD_REQUEST::no-such-user
Line 43: validateParameters(user, "domain.id|name");
Line 44: }
Line 45: String domain = getDomain(user);
Line 46: AdUser adUser = getEntity(AdUser.class,
--
To view, visit http://gerrit.ovirt.org/8329
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2dff7fbca4d3f410e37387922937380f38f7e06e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
