Ori Liel has posted comments on this change.

Change subject: restapi: add alias property to disk and deprecate name
......................................................................


Patch Set 2: (2 inline comments)

one technical comment inside, but also - do we really want to expose 'alias' to 
the user? Why does the user care that Backend uses the terms 'alias'? It's 
simpler for him to think of it as the disk name, no?

....................................................
File 
backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml
Line 309
Line 310
Line 311
Line 312
Line 313
what about backwards compatibility? perhaps better "#deprecated, replaced by", 
as in size


Line 634
Line 635
Line 636
Line 637
Line 638
backwards compatibility


--
To view, visit http://gerrit.ovirt.org/8326
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia93d9abd29e51239f64ae1b43306d44f10ae7af5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to