Juan Hernandez has posted comments on this change.
Change subject: packaging: Validate configuration directory exists before files
creation
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File packaging/fedora/setup/engine-upgrade.py
Line 814: print MSG_ERROR_PGPASS
Line 815: sys.exit(1)
Line 816: else:
Line 817: logging.info("Info: Found .pgpass file at old location.
Moving it to a new location.")
Line 818: os.makedirs(os.path.dirname(basedefs.DB_PASS_FILE))
Won't this fail if the directory does exist? What about this:
dbPassFileDirectory = os.path.dirname(basedefs.DB_PASS_FILE)
if not os.path.exists(dbPassFileDirectory):
os.makedirs(osPassFileDirectory)
Line 819: shutil.copy(basedefs.ORIG_PASS_FILE,
basedefs.DB_PASS_FILE)
Line 820:
Line 821: # File is copied/created by root, so no need to verify
the owner.
Line 822: os.chmod(basedefs.DB_PASS_FILE, 0600)
--
To view, visit http://gerrit.ovirt.org/8340
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4f9f0868568ce56fcfc9566a0adb2b07736b3af
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
