Ori Liel has posted comments on this change.

Change subject: restapi: #855890 - Direct-LUN Disk Creation - Dont Require Size
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File 
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmDisksResource.java
Line 49:               SUB_COLLECTIONS);
Line 50:     }
Line 51: 
Line 52:     @Override
Line 53:     public Response add(Disk disk) {
you are in "Create-LUN Disk Creation should not require size", I think all your 
comments here are addressing a different patch
Line 54:         validateEnums(Disk.class, disk);
Line 55:         if (disk.isSetId()) {
Line 56:             return attachDiskToVm(disk);
Line 57:         }else {


--
To view, visit http://gerrit.ovirt.org/8331
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8dba8d1e1b20ff5f81d9cfa944d3bfcd5630bc1
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to