Juan Hernandez has posted comments on this change.
Change subject: pki: use utc dates when communicating with openssl
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
A minor comment inside.
....................................................
File packaging/fedora/setup/engine-setup.py
Line 751: date = (
Line 752: datetime.datetime.utcnow() + datetime.timedelta(-1)
Line 753: ).strftime(
Line 754: "%y%m%d%H%M%S+0000"
Line 755: )
Can you put this in two lines, with the variable? I think it is easier to
understand:
yesterday = ...
date = yesterday.strftime(...)
You may also want to do "utcnow() - datetime.timedelta(1)". I know you didn't
change it, but feels more natural.
Line 756: logging.debug("Date string is %s", date)
Line 757:
Line 758: # Add random string to certificate CN field
Line 759: randInt = random.randint(10000,99999)
--
To view, visit http://gerrit.ovirt.org/8364
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I446bd9cc712b345bcf267bf6f5cd23dfc9fdea97
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
