anmolbabu has posted comments on this change. Change subject: webadmin : Import cluster bug ......................................................................
Patch Set 1: (8 comments) https://gerrit.ovirt.org/#/c/35864/1//COMMIT_MSG Commit Message: Line 4: Commit: Anmol Babu <[email protected]> Line 5: CommitDate: 2014-12-04 12:05:46 +0530 Line 6: Line 7: webadmin : Import cluster bug Line 8: > Please add some detail regarding the fix and the bug so that it will be eas Done Line 9: Import cluster bug Line 10: Line 11: Change-Id: I6ef25918d18f6e6544622369a42affa365538ee4 Line 12: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1103459 https://gerrit.ovirt.org/#/c/35864/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java: Line 1703: isAllCanDoPassed > this will be true always. So this can be removed from the check. How ? The one after assignment operator is the status untill the last checked in the loop. The one before it, however is the net till now(including the current iteration). Also, I just refactored the in ClusterListModel and moved it here bcoz there are 2 people needing it ClusterListModel and DataCenterListModel and we can simply avoid replicating them all over Line 2008: if (host.getValue() == null || host.getValue().equals("")) > StringUtils.isEmpty() can be used here Done https://gerrit.ovirt.org/#/c/35864/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java: Line 1409: cancel(); : postAction(); > remove this change Done Line 1689: //updateOptions(); > why are u commenting this method? Done https://gerrit.ovirt.org/#/c/35864/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java: Line 634: } Line 635: }, model); Line 636: } Line 637: Line 638: public void importClusterHosts(ClusterModel clusterModel, ArrayList<EntityModel<HostDetailModel>> hostList, UICommand addMultipleHostsCommand) > How this method is different from ClusterListModel.importClusterHosts No they are the same I just wanted it here because I tend to belief that actions/commands can be handled only from list models. I tend to believe in this very often because of the fact that in our xyzModules(ex: VolumeModule) where we instruct our providers that when a specific command is executed, get xyz popupprovider and this is so because list models are bound to popup's of our main and sub tabs. Somehow I get entangled in this and end up in this kind of a situation only to end up realizing some time later. :(( Line 639: { Line 640: addMultipleHostsCommand.execute(); Line 641: Line 642: final MultipleHostsModel hostsModel = new MultipleHostsModel(); Line 640: addMultipleHostsCommand.execute(); > Where this being handled? So here when I am saying command.execute only so that the flow goes to the DataCenterModule and executes the appropriate popup provider Line 1078: onSaveHosts(); Line 1079: } Line 1080: } Line 1081: Line 1082: private void onSaveHosts() > This also similar to what is being done in ClusterListModel.onSaveHosts() Done Line 1083: { Line 1084: MultipleHostsModel hostsModel = (MultipleHostsModel) getWindow(); Line 1085: if(hostsModel == null) Line 1086: { -- To view, visit https://gerrit.ovirt.org/35864 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ef25918d18f6e6544622369a42affa365538ee4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
