Simone Tiraboschi has uploaded a new change for review. Change subject: packaging: setup: print rpm updates list ......................................................................
packaging: setup: print rpm updates list Printing rpm updates list asking user confirmation. Change-Id: Ie38d46a69d6b530caae15e43591315990e5d8dd4 Bug-Url: https://bugzilla.redhat.com/1168629 Signed-off-by: Simone Tiraboschi <[email protected]> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/distro-rpm/packages.py 1 file changed, 16 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/42/40342/1 diff --git a/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/distro-rpm/packages.py b/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/distro-rpm/packages.py index 38bdfd2..0d0dda1 100644 --- a/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/distro-rpm/packages.py +++ b/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/distro-rpm/packages.py @@ -210,6 +210,7 @@ sink=self._getSink(), disabledPlugins=('versionlock',), ) + plist = [] with myum.transaction(): groups = [group['name'] for group in myum.queryGroups()] for entry in self.environment[ @@ -224,12 +225,19 @@ if myum.buildTransaction(): upgradeAvailable = True - # Some debug for p in myum.queryTransaction(): self.logger.debug('PACKAGE: [%s] %s' % ( p['operation'], p['display_name'] )) + plist.append( + _( + 'PACKAGE: [{operation}] {display_name}' + ).format( + operation=p['operation'], + display_name=p['display_name'] + ) + ) # Verify all installed packages available in yum for package in myum.queryTransaction(): @@ -252,7 +260,7 @@ if installed and not reinstall_available: haveRollback = False break - return (upgradeAvailable, haveRollback) + return (upgradeAvailable, haveRollback, plist) def __init__(self, context): super(Plugin, self).__init__(context=context) @@ -337,6 +345,7 @@ ( upgradeAvailable, haveRollback, + plist, ) = self._checkForProductUpdate() if not upgradeAvailable: @@ -348,9 +357,12 @@ dialog=self.dialog, name='OVESETUP_RPMDISTRO_PACKAGE_UPGRADE', note=_( - 'Setup has found updates for some packages, ' + 'Setup has found updates for some packages:\n' + '{plist}\n' 'do you wish to update them now? ' '(@VALUES@) [@DEFAULT@]: ' + ).format( + plist='\n'.join(plist) ), prompt=True, true=_('Yes'), @@ -382,6 +394,7 @@ ( upgradeAvailable, haveRollback, + plist, ) = self._checkForProductUpdate() if not upgradeAvailable: -- To view, visit https://gerrit.ovirt.org/40342 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie38d46a69d6b530caae15e43591315990e5d8dd4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
