Allon Mureinik has uploaded a new change for review. Change subject: core: Findbugs: ISingleAsyncOperation.Execute(int) ......................................................................
core: Findbugs: ISingleAsyncOperation.Execute(int) Renamed the Execute(int) method to execute(int) in ISingleAsyncOperation and its implementing classes, in order to solve the FindBugs warning about it (NM_METHOD_NAMING_CONVENTION) Change-Id: Ie734cca9af6a5863495acd492ebd83d141edb6b2 Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ActivateDeactivateSingleAsyncOperation.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AfterDeactivateSingleAsyncOperation.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectSingleAsyncOperation.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConntectVDSToPoolAndDomains.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DisconnectStoragePoolAsyncOperation.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RefreshPoolSingleAsyncOperation.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RefreshStoragePoolAndDisconnectAsyncOperation.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ISingleAsyncOperation.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/SyncronizeNumberOfAsyncOperations.java 9 files changed, 9 insertions(+), 9 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/92/8392/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ActivateDeactivateSingleAsyncOperation.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ActivateDeactivateSingleAsyncOperation.java index 26e3e46..438e814 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ActivateDeactivateSingleAsyncOperation.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ActivateDeactivateSingleAsyncOperation.java @@ -15,7 +15,7 @@ _pool = storagePool; } - public abstract void Execute(int iterationId); + public abstract void execute(int iterationId); protected storage_domains getStorageDomain() { return _domain; diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AfterDeactivateSingleAsyncOperation.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AfterDeactivateSingleAsyncOperation.java index 687f538..c6b5c2f 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AfterDeactivateSingleAsyncOperation.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AfterDeactivateSingleAsyncOperation.java @@ -24,7 +24,7 @@ } @Override - public void Execute(int iterationId) { + public void execute(int iterationId) { try { log.infoFormat("After deactivate treatment vds: {0},pool {1}", getVdss().get(iterationId).getvds_name(), getStoragePool().getname()); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectSingleAsyncOperation.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectSingleAsyncOperation.java index 00b5f92..864c50f 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectSingleAsyncOperation.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectSingleAsyncOperation.java @@ -13,7 +13,7 @@ } @Override - public void Execute(int iterationId) { + public void execute(int iterationId) { try { StorageHelperDirector.getInstance().getItem(getStorageDomain().getstorage_type()) .ConnectStorageToDomainByVdsId(getStorageDomain(), getVdss().get(iterationId).getId()); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConntectVDSToPoolAndDomains.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConntectVDSToPoolAndDomains.java index 0d625a4..44585cf 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConntectVDSToPoolAndDomains.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConntectVDSToPoolAndDomains.java @@ -20,7 +20,7 @@ } @Override - public void Execute(int iterationId) { + public void execute(int iterationId) { VDS vds = getVdss().get(iterationId); try { boolean isConnectSuccessed = diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DisconnectStoragePoolAsyncOperation.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DisconnectStoragePoolAsyncOperation.java index 3971342..676614a 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DisconnectStoragePoolAsyncOperation.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DisconnectStoragePoolAsyncOperation.java @@ -15,7 +15,7 @@ } @Override - public void Execute(int iterationId) { + public void execute(int iterationId) { try { if (getVdss().get(iterationId).getspm_status() == VdsSpmStatus.None) { log.infoFormat("Disconnect storage pool treatment vds: {0},pool {1}", getVdss().get(iterationId) diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RefreshPoolSingleAsyncOperation.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RefreshPoolSingleAsyncOperation.java index c104bd3..d38dff0 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RefreshPoolSingleAsyncOperation.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RefreshPoolSingleAsyncOperation.java @@ -25,7 +25,7 @@ } @Override - public void Execute(int iterationId) { + public void execute(int iterationId) { try { Guid masterDomainIdFromDb = DbFacade.getInstance() diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RefreshStoragePoolAndDisconnectAsyncOperation.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RefreshStoragePoolAndDisconnectAsyncOperation.java index 8b7eba6..952eccb 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RefreshStoragePoolAndDisconnectAsyncOperation.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RefreshStoragePoolAndDisconnectAsyncOperation.java @@ -18,7 +18,7 @@ } @Override - public void Execute(int iterationId) { + public void execute(int iterationId) { try { Guid masterDomainIdFromDb = DbFacade.getInstance() diff --git a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ISingleAsyncOperation.java b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ISingleAsyncOperation.java index 587757f..6d8197a 100644 --- a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ISingleAsyncOperation.java +++ b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ISingleAsyncOperation.java @@ -1,5 +1,5 @@ package org.ovirt.engine.core.utils; public interface ISingleAsyncOperation { - void Execute(int iterationId); + void execute(int iterationId); } diff --git a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/SyncronizeNumberOfAsyncOperations.java b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/SyncronizeNumberOfAsyncOperations.java index 77b5620..6c6c58b 100644 --- a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/SyncronizeNumberOfAsyncOperations.java +++ b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/SyncronizeNumberOfAsyncOperations.java @@ -27,7 +27,7 @@ public void run() { try { ISingleAsyncOperation operation = _factory.CreateSingleAsyncOperation(); - operation.Execute(currentEventId); + operation.execute(currentEventId); } finally { latch.countDown(); } -- To view, visit http://gerrit.ovirt.org/8392 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie734cca9af6a5863495acd492ebd83d141edb6b2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
