Allon Mureinik has uploaded a new change for review. Change subject: core: FB: ISingleAsyncOperationFactory.CreateSingleAsyncOperation ......................................................................
core: FB: ISingleAsyncOperationFactory.CreateSingleAsyncOperation Renamed the CreateSingleAsyncOperation() method to createSingleAsyncOperation() in ISingleAsyncOperationFactory and its implementing classes, in order to solve the FindBugs warning about it (NM_METHOD_NAMING_CONVENTION). Change-Id: I505809682c70082f7176c6d7365a31a4bf3dca8a Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ActivateDeactivateSingleAsyncOperationFactory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AfterDeactivateSingleAsyncOperationFactory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectSingleAsyncOperationFactory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DisconnectStoragePoolAsyncOperationFactory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RefreshPoolSingleAsyncOperationFactory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RefreshStoragePoolAndDisconnectAsyncOperationFactory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ISingleAsyncOperationFactory.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/SyncronizeNumberOfAsyncOperations.java 9 files changed, 9 insertions(+), 9 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/94/8394/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ActivateDeactivateSingleAsyncOperationFactory.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ActivateDeactivateSingleAsyncOperationFactory.java index c9be7d9..4caff5d 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ActivateDeactivateSingleAsyncOperationFactory.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ActivateDeactivateSingleAsyncOperationFactory.java @@ -44,5 +44,5 @@ _storagePool = (storage_pool) parameters.get(2); } - public abstract ISingleAsyncOperation CreateSingleAsyncOperation(); + public abstract ISingleAsyncOperation createSingleAsyncOperation(); } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AfterDeactivateSingleAsyncOperationFactory.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AfterDeactivateSingleAsyncOperationFactory.java index 8f782df..d815195 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AfterDeactivateSingleAsyncOperationFactory.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AfterDeactivateSingleAsyncOperationFactory.java @@ -8,7 +8,7 @@ private Guid _newMasterStorageDomainId = new Guid(); @Override - public ISingleAsyncOperation CreateSingleAsyncOperation() { + public ISingleAsyncOperation createSingleAsyncOperation() { return new AfterDeactivateSingleAsyncOperation(getVdss(), getStorageDomain(), getStoragePool(), _isLastMaster, _newMasterStorageDomainId); } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectSingleAsyncOperationFactory.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectSingleAsyncOperationFactory.java index e884eae..dea5ce0 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectSingleAsyncOperationFactory.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectSingleAsyncOperationFactory.java @@ -4,7 +4,7 @@ public class ConnectSingleAsyncOperationFactory extends ActivateDeactivateSingleAsyncOperationFactory { @Override - public ISingleAsyncOperation CreateSingleAsyncOperation() { + public ISingleAsyncOperation createSingleAsyncOperation() { return new ConnectSingleAsyncOperation(getVdss(), getStorageDomain(), getStoragePool()); } } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DisconnectStoragePoolAsyncOperationFactory.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DisconnectStoragePoolAsyncOperationFactory.java index 5299fd8..01c118d 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DisconnectStoragePoolAsyncOperationFactory.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DisconnectStoragePoolAsyncOperationFactory.java @@ -4,7 +4,7 @@ public class DisconnectStoragePoolAsyncOperationFactory extends ActivateDeactivateSingleAsyncOperationFactory { @Override - public ISingleAsyncOperation CreateSingleAsyncOperation() { + public ISingleAsyncOperation createSingleAsyncOperation() { return new DisconnectStoragePoolAsyncOperation(getVdss(), getStoragePool()); } } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RefreshPoolSingleAsyncOperationFactory.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RefreshPoolSingleAsyncOperationFactory.java index 70dcb03..aa37c4f 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RefreshPoolSingleAsyncOperationFactory.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RefreshPoolSingleAsyncOperationFactory.java @@ -22,7 +22,7 @@ } @Override - public ISingleAsyncOperation CreateSingleAsyncOperation() { + public ISingleAsyncOperation createSingleAsyncOperation() { ISingleAsyncOperation tempVar = new RefreshPoolSingleAsyncOperation(getVdss(), getStorageDomain(), getStoragePool(), _vdsIdsToSetNonOperational); return tempVar; diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RefreshStoragePoolAndDisconnectAsyncOperationFactory.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RefreshStoragePoolAndDisconnectAsyncOperationFactory.java index b5ffb28..9ce71c1 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RefreshStoragePoolAndDisconnectAsyncOperationFactory.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RefreshStoragePoolAndDisconnectAsyncOperationFactory.java @@ -5,7 +5,7 @@ public class RefreshStoragePoolAndDisconnectAsyncOperationFactory extends ActivateDeactivateSingleAsyncOperationFactory { @Override - public ISingleAsyncOperation CreateSingleAsyncOperation() { + public ISingleAsyncOperation createSingleAsyncOperation() { return new RefreshStoragePoolAndDisconnectAsyncOperation(getVdss(), getStorageDomain(), getStoragePool()); } } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java index b7851b8..3ed129c 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java @@ -370,7 +370,7 @@ null, new ActivateDeactivateSingleAsyncOperationFactory() { @Override - public ISingleAsyncOperation CreateSingleAsyncOperation() { + public ISingleAsyncOperation createSingleAsyncOperation() { return new ConntectVDSToPoolAndDomains((ArrayList<VDS>) vdsList, masterDomain, storagePool); } diff --git a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ISingleAsyncOperationFactory.java b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ISingleAsyncOperationFactory.java index 7dd9651..73f2a4b 100644 --- a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ISingleAsyncOperationFactory.java +++ b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ISingleAsyncOperationFactory.java @@ -3,5 +3,5 @@ public interface ISingleAsyncOperationFactory { void initialize(java.util.ArrayList parameters); - ISingleAsyncOperation CreateSingleAsyncOperation(); + ISingleAsyncOperation createSingleAsyncOperation(); } diff --git a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/SyncronizeNumberOfAsyncOperations.java b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/SyncronizeNumberOfAsyncOperations.java index e9d3547..f977fe1 100644 --- a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/SyncronizeNumberOfAsyncOperations.java +++ b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/SyncronizeNumberOfAsyncOperations.java @@ -26,7 +26,7 @@ @Override public void run() { try { - ISingleAsyncOperation operation = _factory.CreateSingleAsyncOperation(); + ISingleAsyncOperation operation = _factory.createSingleAsyncOperation(); operation.execute(currentEventId); } finally { latch.countDown(); -- To view, visit http://gerrit.ovirt.org/8394 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I505809682c70082f7176c6d7365a31a4bf3dca8a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
