Hello Shmuel Melamud,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/40354
to review the following change.
Change subject: core: Run AddVmToPool command in a separate context
......................................................................
core: Run AddVmToPool command in a separate context
AddVmToPool command called from AddVmAndAttachToPool command was
executed in the same context that led to creation of two EXECUTING steps
in the same job. Because of that the job wasn't finalized correctly and
was stuck in 'started' state.
Change-Id: I98bc432dbcee9356e1cac536d1f342fa6b18a310
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1211512
Signed-off-by: Shmuel Melamud <[email protected]>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndAttachToPoolCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/54/40354/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndAttachToPoolCommand.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndAttachToPoolCommand.java
index a64f391..59335e1 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndAttachToPoolCommand.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndAttachToPoolCommand.java
@@ -90,7 +90,7 @@
AddVmToPoolParameters parameters = new
AddVmToPoolParameters(getParameters().getPoolId(),
vmStatic.getId());
parameters.setShouldBeLogged(false);
- setSucceeded(runInternalAction(VdcActionType.AddVmToPool,
parameters).getSucceeded());
+
setSucceeded(runInternalActionWithTasksContext(VdcActionType.AddVmToPool,
parameters).getSucceeded());
addVmPermission();
}
}
--
To view, visit https://gerrit.ovirt.org/40354
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I98bc432dbcee9356e1cac536d1f342fa6b18a310
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud <[email protected]>
Gerrit-Reviewer: Shmuel Melamud <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
