Yair Zaslavsky has posted comments on this change. Change subject: core: Improving RegisterVdsQuery ......................................................................
Patch Set 1: Looks good to me, approved (1 inline comment) Minor typo, fix and submit .................................................... Commit Message Line 8: Line 9: The following patch is clean up and improving of RegisterVdsQuery. Line 10: The patch doesn't contains all improvements, these is only a first step Line 11: Current improvements: Line 12: 1. Removed unneeded opening of threads - we opened a thread but still wait untill s/untill/until Line 13: it will finished, no reason for that Line 14: 2. Removed unneeded global transaction - never good Line 15: 3. Some small code clean ups Line 16: -- To view, visit http://gerrit.ovirt.org/8419 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida0d776fa5d24a2b68c774a82d5cda0b67c70f44 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
