Michael Kublin has uploaded a new change for review. Change subject: core: Fixing comparison bug at UpdateVdsCommand ......................................................................
core: Fixing comparison bug at UpdateVdsCommand The following bug is simple: comparison should be done by using equals and not != operator Change-Id: I6155a06800b738d7238e919d6311591d82851baf Signed-off-by: Michael Kublin <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/21/8421/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsCommand.java index b409753..b29d52c 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsCommand.java @@ -132,7 +132,7 @@ InitializeVds(); } // if host_name changed and host is spm we need to update irsBroker cache with the new host_name - if (_oldVds.getstorage_pool_id() != Guid.Empty && _oldVds.getspm_status() != VdsSpmStatus.None && + if (!Guid.Empty.equals(_oldVds.getstorage_pool_id()) && _oldVds.getspm_status() != VdsSpmStatus.None && !StringUtils.equals(_oldVds.gethost_name(), getParameters().getVdsStaticData().gethost_name())) { Backend.getInstance() .getResourceManager() -- To view, visit http://gerrit.ovirt.org/8421 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6155a06800b738d7238e919d6311591d82851baf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
