Arik Hadas has posted comments on this change. Change subject: RFE: Report downtime for each live migration ......................................................................
Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/40100/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java: Line 193: } Line 194: } Line 195: Line 196: protected void getDowntime() { Line 197: if (getVm() != null && getVm().getStatus() == VMStatus.Up) { 1. I don't think it is needed to check the VM is not null - it is locked, no one can remove it 2. why is it important that the status is up? what if it is powering-up? Line 198: try { Line 199: VDSReturnValue retVal = runVdsCommand(VDSCommandType.MigrateStatus, Line 200: new MigrateStatusVDSCommandParameters(getDestinationVdsId(), getVmId())); Line 201: if (retVal != null) { https://gerrit.ovirt.org/#/c/40100/1/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/MigrateStatusVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/MigrateStatusVDSCommand.java: Line 27: } Line 28: Line 29: public void setDowntime(Long downtime) { Line 30: this.downtime = downtime; Line 31: } why having the 'downtime' field and its setter/getter? I don't see that they are used.. -- To view, visit https://gerrit.ovirt.org/40100 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic18c6db9a85167b1c4b85bdad22cf63f0204f378 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
