Tomas Jelinek has posted comments on this change. Change subject: frontend: Implementation support for GuestOsInfo and Timezone reporting ......................................................................
Patch Set 11: (3 comments) only very small comments https://gerrit.ovirt.org/#/c/33376/11/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationMessages.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationMessages.java: Line 186: String numaNode(int index); Line 187: Line 188: @DefaultMessage("{0}: {1}") Line 189: String migratingProgress(String status, String progress); Line 190: please remove this on rebase https://gerrit.ovirt.org/#/c/33376/11/frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml File frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml: Line 176: <include name="common/businessentities/ImageType.java" /> Line 177: <include name="common/businessentities/SnapshotActionEnum.java"/> Line 178: <include name="common/businessentities/VmRngDevice.java" /> Line 179: <include name="common/locks/LockInfo.java" /> Line 180: <include name="common/businessentities/OsType.java" /> please remove the tabs Line 181: <include name="common/job/*.java" /> Line 182: Line 183: <!-- Console --> Line 184: <include name="common/console/*.java" /> https://gerrit.ovirt.org/#/c/33376/11/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java File frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java: Line 722 Line 723 Line 724 Line 725 Line 726 please rename also the method -- To view, visit https://gerrit.ovirt.org/33376 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia7f9ae95b2b9fe9affa27886a7981bcdffabee49 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Martin Betak <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
