Alona Kaplan has posted comments on this change.
Change subject: webadmin: "Fully configured" message for guide me dialogs
(#850439)
......................................................................
Patch Set 1: (5 inline comments)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AbstractUiCommandButton.java
Line 55: getButtonWidget().setVisible(command.getIsAvailable() &&
command.getIsVisible());
Line 56: getButtonWidget().setEnabled(command.getIsExecutionAllowed());
Line 57:
Line 58: // Use prohibition reasons for tooltip if exist.
Line 59:
getButtonWidget().setTitle(!command.getExecuteProhibitionReasons().isEmpty()
why don't
getButtonWidget().setTitle(!command.getExecuteProhibitionReasons().isEmpty()
?command.getExecuteProhibitionReasons().get(0)
: command.getTitle());
Line 60: ? command.getExecuteProhibitionReasons().isEmpty()
Line 61: ? null
Line 62: : command.getExecuteProhibitionReasons().get(0)
Line 63: : command.getTitle());
Line 58: // Use prohibition reasons for tooltip if exist.
Line 59:
getButtonWidget().setTitle(!command.getExecuteProhibitionReasons().isEmpty()
Line 60: ? command.getExecuteProhibitionReasons().isEmpty()
Line 61: ? null
Line 62: : command.getExecuteProhibitionReasons().get(0)
why do you show just the first one and not all the reasons?
Line 63: : command.getTitle());
Line 64:
Line 65: if (command.getTitle() != null) {
Line 66: getButtonWidget().setText(command.getTitle());
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGuideModel.java
Line 185: .getConstants()
Line 186:
.thisClusterBelongsToALocalDcWhichAlreadyContainHostClusterGuide();
Line 187:
Line 188:
addHostAction.getExecuteProhibitionReasons().add(hasHostReason);
Line 189: addHostAction.setIsExecutionAllowed(false);
Maybe AbstractUiCommandButton can also listen to changes in
ExecuteProhibitionReasons list. To avoid bugs when using the wrong order (and
allow changing the reasons while the execution is not allowed).
Line 190:
selectHost.getExecuteProhibitionReasons().add(hasHostReason);
Line 191: selectHost.setIsExecutionAllowed(false);
Line 192: }
Line 193:
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
Line 748:
Line 749: @DefaultStringValue("Configuration completed.")
Line 750: String guidePopupConfigurationCompletedLabel();
Line 751:
Line 752: @DefaultStringValue("Data Center created.")
please separate to another patch
Line 753: String guidePopupDataCenterCreatedLabel();
Line 754:
Line 755: @DefaultStringValue("The Data Center is fully configured and
ready for use.")
Line 756: String guidePopupConfiguredDataCenterLabel();
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/guide/GuidePopupView.java
Line 11: import com.google.gwt.uibinder.client.UiField;
Line 12: import com.google.gwt.user.client.ui.Label;
Line 13: import com.google.gwt.user.client.ui.VerticalPanel;
Line 14: import com.google.inject.Inject;
Line 15: import org.ovirt.engine.core.compat.Event;
please separate to another patch
Line 16: import org.ovirt.engine.core.compat.EventArgs;
Line 17: import org.ovirt.engine.core.compat.IEventListener;
Line 18: import org.ovirt.engine.core.compat.PropertyChangedEventArgs;
Line 19: import org.ovirt.engine.ui.common.idhandler.ElementIdHandler;
--
To view, visit http://gerrit.ovirt.org/8435
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I16d72904dfebe8fa0a29065e587c829998da782f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexey Chub <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
