Yair Zaslavsky has posted comments on this change.
Change subject: engine: Refresh gluster data periodically
......................................................................
Patch Set 17: (1 inline comment)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/ListUtils.java
Line 108: * <code>newList</code>
Line 109: *
Line 110: * @param oldList
Line 111: * @param newList
Line 112: * @return collection of elements that are not present in
<code>oldList</code>, but present in <code>newList</code>
About my previous comment - for some reason I assumed that Set API will have
better performance - even if at first you need to pay the price of adding the
two collections to a set.
Maybe you should at least consider adding the oldList collection to a set, and
thus verifying the complexity of the contains method is O(1) avg?
Line 113: */
Line 114: public static <T> Collection<T> getAddedElements(Collection<T>
oldList, Collection<T> newList) {
Line 115: List<T> addedElements = new ArrayList<T>();
Line 116: for (T element : newList) {
--
To view, visit http://gerrit.ovirt.org/7288
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b61eb6e93105e46e2706eac1d94bc10717224c2
Gerrit-PatchSet: 17
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
