Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: asking again on wrong engine password ......................................................................
Patch Set 2: -Code-Review (1 comment) https://gerrit.ovirt.org/#/c/40347/2/src/plugins/ovirt-hosted-engine-setup/engine/add_host.py File src/plugins/ovirt-hosted-engine-setup/engine/add_host.py: Line 528: self._getSSHkey() Line 529: cluster_name = None Line 530: default_cluster_name = 'Default' Line 531: valid = False Line 532: while not valid: Hold on, what about unattended setup? If the password is provided by answer file, here looks like it will end blocked on user input here. Line 533: try: Line 534: self.logger.info(_('Connecting to the Engine')) Line 535: engine_api = self._ovirtsdk_api.API( Line 536: url='https://{fqdn}/ovirt-engine/api'.format( -- To view, visit https://gerrit.ovirt.org/40347 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieabac668ee21d2f023cfb2b8167e5626553e5d27 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Lev Veyde <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
