Arik Hadas has posted comments on this change. Change subject: RFE: Report downtime for each live migration ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/40100/3/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/MigrateStatusVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/MigrateStatusVDSCommand.java: Line 19: @Override Line 20: protected StatusForXmlRpc getReturnStatus() { Line 21: return status; Line 22: } Line 23: } no need to add the 'status' field and override 'getReturnStatus', right? -- To view, visit https://gerrit.ovirt.org/40100 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic18c6db9a85167b1c4b85bdad22cf63f0204f378 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
