Sandro Bonazzola has posted comments on this change. Change subject: restapi: Introduce current filter ......................................................................
Patch Set 1: (10 comments) inline comments, not related to code. looks like most of the java code is missing license header. https://gerrit.ovirt.org/#/c/40150/1/backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/invocation/Current.java File backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/invocation/Current.java: Line 1: /* Line 2: * Copyright (c) 2014 Red Hat, Inc. 2010-2015 Line 3: * Line 4: * Licensed under the Apache License, Version 2.0 (the "License"); Line 5: * you may not use this file except in compliance with the License. Line 6: * You may obtain a copy of the License at https://gerrit.ovirt.org/#/c/40150/1/backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/invocation/CurrentFilter.java File backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/invocation/CurrentFilter.java: Line 1: /* Line 2: * Copyright (c) 2014 Red Hat, Inc. 2015 Line 3: * Line 4: * Licensed under the Apache License, Version 2.0 (the "License"); Line 5: * you may not use this file except in compliance with the License. Line 6: * You may obtain a copy of the License at https://gerrit.ovirt.org/#/c/40150/1/backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/invocation/CurrentManager.java File backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/invocation/CurrentManager.java: Line 1: /* Line 2: * Copyright (c) 2014 Red Hat, Inc. 2015 Line 3: * Line 4: * Licensed under the Apache License, Version 2.0 (the "License"); Line 5: * you may not use this file except in compliance with the License. Line 6: * You may obtain a copy of the License at https://gerrit.ovirt.org/#/c/40150/1/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/BackendApplication.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/BackendApplication.java: Line 1: /* 2010-2015 Line 2: * Copyright (c) 2010 Red Hat, Inc. Line 3: * Line 4: * Licensed under the Apache License, Version 2.0 (the "License"); Line 5: * you may not use this file except in compliance with the License. https://gerrit.ovirt.org/#/c/40150/1/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java: Line 1: /* 2010-2015 Line 2: * Copyright (c) 2010 Red Hat, Inc. Line 3: * Line 4: * Licensed under the Apache License, Version 2.0 (the "License"); Line 5: * you may not use this file except in compliance with the License. https://gerrit.ovirt.org/#/c/40150/1/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAssignedPermissionsResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAssignedPermissionsResource.java: Missing license header Line 1: package org.ovirt.engine.api.restapi.resource; Line 2: Line 3: import java.io.Serializable; Line 4: import java.util.Comparator; https://gerrit.ovirt.org/#/c/40150/1/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendClustersResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendClustersResource.java: missing license header Line 1: package org.ovirt.engine.api.restapi.resource; Line 2: Line 3: import java.util.List; Line 4: https://gerrit.ovirt.org/#/c/40150/1/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostsResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostsResource.java: Line 1: package org.ovirt.engine.api.restapi.resource; missing license header Line 2: Line 3: import java.util.LinkedList; Line 4: import java.util.List; Line 5: import java.util.Set; https://gerrit.ovirt.org/#/c/40150/1/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendResource.java: Line 1: package org.ovirt.engine.api.restapi.resource; missing license header Line 2: Line 3: import java.lang.reflect.InvocationTargetException; Line 4: import java.lang.reflect.Method; Line 5: import java.text.MessageFormat; https://gerrit.ovirt.org/#/c/40150/1/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolResource.java: Line 1: package org.ovirt.engine.api.restapi.resource; missing license header Line 2: Line 3: Line 4: import static org.ovirt.engine.api.restapi.resource.BackendVmPoolsResource.SUB_COLLECTION; Line 5: -- To view, visit https://gerrit.ovirt.org/40150 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If46bafba6e8b58624af7eb85ae231edb0cf8dc1f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
