Dudi Maroshi has posted comments on this change. Change subject: core: introduce NumaNodePinning entity ......................................................................
Patch Set 10: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/38047/10/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/NumaNodePinning.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/NumaNodePinning.java: Line 16: private Guid physicalNodeId; Line 17: /** Line 18: * pinned or non pinned cell Line 19: */ Line 20: private Mode mode; if the mode is binary, and no other modes expeted in the futue. It is simpler to user boolean. Or Boolean if there is unknown mode. Line 21: /** Line 22: * the index of the related physical node Line 23: */ Line 24: private int index; -- To view, visit https://gerrit.ovirt.org/38047 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib2ebd8f8e8aa87d92f9b01d70639940b0754bc96 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Dudi Maroshi <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
