Martin Betak has posted comments on this change. Change subject: webadmin: change import template model hierarchy ......................................................................
Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/40447/4/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/TemplateBackupModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/TemplateBackupModel.java: Line 230: } Line 231: return true; Line 232: } Line 233: Line 234: protected boolean validateName(String newVmName, EntityModel entity, IValidation[] validators) { would it be possible to make this EntityModel<String>? (in generic patch ofc) Line 235: EntityModel temp = new EntityModel(); Line 236: temp.setIsValid(true); Line 237: temp.setEntity(newVmName); Line 238: temp.validateEntity(validators); Line 231: return true; Line 232: } Line 233: Line 234: protected boolean validateName(String newVmName, EntityModel entity, IValidation[] validators) { Line 235: EntityModel temp = new EntityModel(); same here Line 236: temp.setIsValid(true); Line 237: temp.setEntity(newVmName); Line 238: temp.validateEntity(validators); Line 239: if (!temp.getIsValid()) { -- To view, visit https://gerrit.ovirt.org/40447 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I693f8abbf71d333d90a6dcd37feb4afeecb3f56b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
