Vojtech Szocs has posted comments on this change.

Change subject: webadmin: cluster guide me datacenter
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/37763/2/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/AddDataCenterClusterPopupView.java
File 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/AddDataCenterClusterPopupView.java:

Line 29:     }
Line 30:     private static final ApplicationConstants constants = 
AssetProvider.getConstants();
Line 31: 
Line 32:     @UiField(provided = true)
Line 33:     EntityModelCellTable<ListModel<EntityModel<StoragePool>>> 
dataCentersTable;
> No, otherwise the UI binder complains that the UiField is not visible.
Oh, right, I forgot about the @UiField implication, sorry.
Line 34: 
Line 35:     @Inject
Line 36:     public AddDataCenterClusterPopupView(EventBus eventBus) {
Line 37:         super(eventBus);


-- 
To view, visit https://gerrit.ovirt.org/37763
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifaafdd5593d3721b9e6a8b466b2ac186b18bd6fe
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Greg Sheremeta <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to