Hello Shmuel Melamud,

I'd like you to do a code review.  Please visit

    https://gerrit.ovirt.org/40558

to review the following change.

Change subject: core: Added missing @Override in RemoveVmCommand
......................................................................

core: Added missing @Override in RemoveVmCommand

Change-Id: Ife245557927d27e4aec5ee54fe48186eccb8c784
Signed-off-by: Shmuel Melamud <[email protected]>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java
1 file changed, 9 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/58/40558/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java
index 7c68075..a99f240 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java
@@ -427,18 +427,22 @@
     // TaskHandlerCommand Implementation //
     ///////////////////////////////////////
 
+    @Override
     public T getParameters() {
         return super.getParameters();
     }
 
+    @Override
     public VdcActionType getActionType() {
         return super.getActionType();
     }
 
+    @Override
     public VdcReturnValueBase getReturnValue() {
         return super.getReturnValue();
     }
 
+    @Override
     public Guid createTask(Guid taskId,
             AsyncTaskCreationInfo asyncTaskCreationInfo,
             VdcActionType parentCommand,
@@ -447,12 +451,14 @@
         return super.createTaskInCurrentTransaction(taskId, 
asyncTaskCreationInfo, parentCommand, entityType, entityIds);
     }
 
+    @Override
     public Guid createTask(Guid taskId,
             AsyncTaskCreationInfo asyncTaskCreationInfo,
             VdcActionType parentCommand) {
         return super.createTask(taskId, asyncTaskCreationInfo, parentCommand);
     }
 
+    @Override
     public ArrayList<Guid> getTaskIdList() {
         return super.getTaskIdList();
     }
@@ -462,14 +468,17 @@
         // Not implemented
     }
 
+    @Override
     public void preventRollback() {
         throw new NotImplementedException();
     }
 
+    @Override
     public Guid persistAsyncTaskPlaceHolder() {
         return super.persistAsyncTaskPlaceHolder(getActionType());
     }
 
+    @Override
     public Guid persistAsyncTaskPlaceHolder(String taskKey) {
         return super.persistAsyncTaskPlaceHolder(getActionType(), taskKey);
     }


-- 
To view, visit https://gerrit.ovirt.org/40558
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ife245557927d27e4aec5ee54fe48186eccb8c784
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud <[email protected]>
Gerrit-Reviewer: Shmuel Melamud <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to