Arik Hadas has uploaded a new change for review. Change subject: core: fix permissions check on import vm ......................................................................
core: fix permissions check on import vm Change-Id: If0ebed256f1f7dc90d9472582adbf827ff84d421 Signed-off-by: Arik Hadas <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommandBase.java 1 file changed, 21 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/72/40572/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommandBase.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommandBase.java index cf00705..f7c7f2c 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommandBase.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommandBase.java @@ -4,15 +4,20 @@ import java.util.Collection; import java.util.Date; import java.util.HashMap; +import java.util.HashSet; import java.util.List; import java.util.Map; +import java.util.Set; + import javax.annotation.PostConstruct; import org.apache.commons.lang.StringUtils; import org.ovirt.engine.core.bll.context.CommandContext; import org.ovirt.engine.core.bll.network.VmInterfaceManager; import org.ovirt.engine.core.bll.network.vm.VnicProfileHelper; +import org.ovirt.engine.core.bll.utils.PermissionSubject; import org.ovirt.engine.core.common.AuditLogType; +import org.ovirt.engine.core.common.VdcObjectType; import org.ovirt.engine.core.common.action.ImportVmParameters; import org.ovirt.engine.core.common.action.LockProperties; import org.ovirt.engine.core.common.action.LockProperties.Scope; @@ -412,4 +417,20 @@ return getVm().getMemSizeMb(); } + + @Override + public List<PermissionSubject> getPermissionCheckSubjects() { + Set<PermissionSubject> permissionSet = new HashSet<>(); + // Source domain + permissionSet.add(new PermissionSubject(getParameters().getSourceDomainId(), + VdcObjectType.Storage, + getActionType().getActionGroup())); + // Destination domains + for (Guid storageId : imageToDestinationDomainMap.values()) { + permissionSet.add(new PermissionSubject(storageId, + VdcObjectType.Storage, + getActionType().getActionGroup())); + } + return new ArrayList<>(permissionSet); + } } -- To view, visit https://gerrit.ovirt.org/40572 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If0ebed256f1f7dc90d9472582adbf827ff84d421 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
