Arik Hadas has posted comments on this change. Change subject: events: vm stats refresher refactioring ......................................................................
Patch Set 9: (2 comments) https://gerrit.ovirt.org/#/c/37487/9//COMMIT_MSG Commit Message: Line 7: refactioring s\refactioring\refactoring https://gerrit.ovirt.org/#/c/37487/9/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java: Line 890: if (this.vmsRefresher == null) { Line 891: return false; Line 892: } Line 893: return this.vmsRefresher.getRefreshStatistics(); Line 894: } I understand that you try to minimize the 'behavioral' changes in this patch, however - can we initialize vmRefresher in postConstruct (since you need this instance) and remove the null check (vmRefresher should never be null..) ? Line 895: Line 896: public Object getLockObj() { Line 897: return lockObj; Line 898: } -- To view, visit https://gerrit.ovirt.org/37487 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I40139f9c90bd9ceeb297adf9f8bd3ab7f9113930 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
