Tomas Jelinek has uploaded a new change for review. Change subject: frontend: minor cleanup in ConsoleUtilsImpl ......................................................................
frontend: minor cleanup in ConsoleUtilsImpl In e29af9398c907d834431deadc441c83f803c85ef the only usage of the extractNtVersion() method has been removed but the method itself stayed there - deleted also that one (and it's dependent getUserAgentString()). Change-Id: I8722f5434ff208a4012857b3be0dec692ea70c97 Signed-off-by: Tomas Jelinek <[email protected]> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/ConsoleUtilsImpl.java 1 file changed, 0 insertions(+), 18 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/01/40601/1 diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/ConsoleUtilsImpl.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/ConsoleUtilsImpl.java index 0156e72..88fe571 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/ConsoleUtilsImpl.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/ConsoleUtilsImpl.java @@ -1,7 +1,5 @@ package org.ovirt.engine.ui.common.utils; -import com.google.gwt.regexp.shared.MatchResult; -import com.google.gwt.regexp.shared.RegExp; import com.google.inject.Inject; import org.ovirt.engine.core.common.businessentities.VM; import org.ovirt.engine.core.common.queries.ConfigurationValues; @@ -21,17 +19,6 @@ public ConsoleUtilsImpl(Configurator configurator, ClientAgentType clientAgentType) { this.configurator = configurator; this.clientAgentType = clientAgentType; - } - - private float extractNtVersion(String userAgentType) { - RegExp pattern = RegExp.compile(".*windows nt (\\d+\\.\\d+).*"); //$NON-NLS-1$ - MatchResult matcher = pattern.exec(userAgentType.toLowerCase()); - boolean matchFound = (matcher != null); - if (matchFound) { - return Float.parseFloat(matcher.getGroup(1)); - } - - return -1; } @Override @@ -82,10 +69,5 @@ public boolean isIE11() { return clientAgentType.isIE11(); } - - private native String getUserAgentString() /*-{ - var userAgent = navigator.userAgent; - return userAgent; - }-*/; } -- To view, visit https://gerrit.ovirt.org/40601 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8722f5434ff208a4012857b3be0dec692ea70c97 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
