Greg Sheremeta has uploaded a new change for review. Change subject: webadmin: fixed VMs > Disks de/activate tooltips ......................................................................
webadmin: fixed VMs > Disks de/activate tooltips Change-Id: I34196af6301316687279c8c4dffb95de8d5ce270 Bug-Url: https://bugzilla.redhat.com/1140158 Signed-off-by: Greg Sheremeta <[email protected]> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmDiskListModelTable.java 1 file changed, 4 insertions(+), 11 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/14/40614/1 diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmDiskListModelTable.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmDiskListModelTable.java index 82a4303..b27916a 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmDiskListModelTable.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmDiskListModelTable.java @@ -80,14 +80,11 @@ @Override public SafeHtml getTooltip() { - String tooltip = null; if (!getModel().isVmDown() && getModel().isHotPlugAvailable() && !getModel().getIsDiskHotPlugSupported()) { - tooltip = constants.diskHotPlugNotSupported(); - } else { - tooltip = this.getText(); + return SafeHtmlUtils.fromString(constants.diskHotPlugNotSupported()); } - return SafeHtmlUtils.fromString(tooltip); + return null; } }; getTable().addActionButton(plugButtonDefinition); @@ -101,15 +98,11 @@ @Override public SafeHtml getTooltip() { - String tooltip = null; if (!getModel().isVmDown() && getModel().isHotPlugAvailable() && !getModel().getIsDiskHotPlugSupported()) { - tooltip = constants.diskHotPlugNotSupported(); + return SafeHtmlUtils.fromString(constants.diskHotPlugNotSupported()); } - else { - tooltip = this.getText(); - } - return SafeHtmlUtils.fromString(tooltip); + return null; } }; getTable().addActionButton(unPlugButtonDefinition); -- To view, visit https://gerrit.ovirt.org/40614 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I34196af6301316687279c8c4dffb95de8d5ce270 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
