Moti Asayag has posted comments on this change.
Change subject: engine: Get Volume Advanced Details Query
......................................................................
Patch Set 16: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeAdvancedDetailsQuery.java
Line 89: return ClusterUtils.getInstance();
Line 90: }
Line 91:
Line 92: protected VDSBrokerFrontend getBackendResourceManager() {
Line 93: return Backend.getInstance()
s/Backend.getInstance()/getBackend()
Line 94: .getResourceManager();
Line 95: }
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GetGlusterVolumeAdvancedDetailsVDSCommand.java
Line 23: }
Line 24:
Line 25: @Override
Line 26: protected void ExecuteVdsBrokerCommand() {
Line 27: GlusterVolumeAdvancedDetails volumeAdvancedDetails = new
GlusterVolumeAdvancedDetails();
why there is need to initialize the volumeAdvancedDetails parameter if it is
being overridden two line later ?
Line 28: executeVolumeStatusInfo("");
Line 29: volumeAdvancedDetails = result.getVolumeAdvancedDetails();
Line 30:
Line 31: if (getParameters().detailsRequired()) {
--
To view, visit http://gerrit.ovirt.org/7807
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If6b590eaebeb1d06b7278300d5e12b2dab9eb093
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dhandapani Gopal <dgo...@redhat.com>
Gerrit-Reviewer: Dhandapani Gopal <dgo...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Selvasundaram <sesub...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
