anmolbabu has posted comments on this change.

Change subject: engine: Georep sync fix deletion of sessions
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

Some minor comments only

https://gerrit.ovirt.org/#/c/40357/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterGeoRepSyncJob.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterGeoRepSyncJob.java:

Line 264:     }
Line 265: 
Line 266:     private void removeDeletedSessions(Guid clusterId,
Line 267:             final Map<String, GlusterGeoRepSession> sessionsMap,
Line 268:             GlusterVolumeEntity volume) {
why not pass only volumeId instead of volume?
Line 269:         List<GlusterGeoRepSession> sessionsInDb;
Line 270:         if (volume != null) {
Line 271:             // syncing for a specific volume, so retrieve only that 
volume's sessions
Line 272:             sessionsInDb = 
getGeoRepDao().getGeoRepSessions(volume.getId());


Line 380:         }
Line 381:         return GeoRepSessionStatus.UNKNOWN;
Line 382:     }
Line 383: 
Line 384:     private Map<String, GlusterGeoRepSession> 
getSessionsFromCLI(VDSGroup cluster, GlusterVolumeEntity volume) {
pass only volumename instead of volume?
Line 385:         VDS upServer = 
getClusterUtils().getRandomUpServer(cluster.getId());
Line 386:         if (upServer == null) {
Line 387:             log.debug("No UP server found in cluster '{}' for geo-rep 
monitoring", cluster.getName());
Line 388:             return null;


-- 
To view, visit https://gerrit.ovirt.org/40357
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib45f071885caf17d1acbc87fde6590476d849dc7
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ramesh N <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: anmolbabu <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to