Allon Mureinik has posted comments on this change. Change subject: core,webadmin: new VM-Template - changeable disk alias ......................................................................
Patch Set 1: I would prefer that you didn't submit this (1 inline comment) possible bug - see inline. -1 is given just so this won't be merged by mistake, although the rest of the code looks fine. .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateImageTemplateCommand.java Line 64: VdcObjectType.Storage, getParameters().getStorageDomainId(), Line 65: getParameters().getDestinationStorageDomainId())); Line 66: Line 67: newImage.setId(destinationImageGroupID); Line 68: newImage.setDiskAlias(getParameters().getDiskAlias()); and if it was not passed as a parameter? wouldn't you want to reuse the existing one? Line 69: newImage.setvm_snapshot_id(getParameters().getVmSnapshotId()); Line 70: newImage.setQuotaId(getParameters().getQuotaId()); Line 71: newImage.setParentId(ImagesHandler.BlankImageTemplateId); Line 72: newImage.setit_guid(ImagesHandler.BlankImageTemplateId); -- To view, visit http://gerrit.ovirt.org/8534 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a6a47d1ba77eed84fa5561db342e03ab6bac81a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Asaf Shakarchi <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
